Status Update
Comments
ss...@google.com <ss...@google.com> #2
Thanks.
mi...@gmail.com <mi...@gmail.com> #3
pe...@google.com <pe...@google.com> #4
pa...@google.com <pa...@google.com> #5
Note: Issue reproducible on Windows 10 and Mac 14.3.1
Reproducible:
===========
Canary- 123.0.6298.0
Dev - 123.0.6286.0
Beta - 122.0.6261.29
Stable - 121.0.6167.160
Bisect Information:
---------------------------------
Good Build: 121.0.6133.0
Bad Build: 121.0.6134.0
Bisect Script: python3 bisect_builds.py -a linux64 -g 1225867 -b 1226072
ChangeLog URL:
Suspect:
Change ID: Ib5a2746e6ee6d9a2b62f5cb71ddc5c23f9228c5f
Reviewed on:
@bmeurer: Please help us in re-assigning if this is not related to your change.
Thanks..!
mi...@gmail.com <mi...@gmail.com> #6
Because for me (html coder), and not only for me, this is bad ux.
bm...@google.com <bm...@google.com> #7
Can you elaborate what exactly bothers you? The automatic pretty printing should be a net-win in terms of UX, and in those rare cases where you need to see the precise wire representation, you can always turn it off via the pretty print {} toggle in each editor window. Do you have concrete examples where pretty printing does a bad job?
mi...@gmail.com <mi...@gmail.com> #8
Firstly, I have to constantly switch to the default type of css code, because I write a css string and this is my writing style, which I want to maintain in the future.
Secondly, when using the toolbar, the pretty print object property is applied automatically and destroys the entire CSS code. I recorded a video.
pe...@google.com <pe...@google.com> #9
pe...@google.com <pe...@google.com> #10
Some values couldn't be corrected but were removed, please verify that any important data wasn't lost.
You can see the changes by toggling full history on the issue.
al...@gmail.com <al...@gmail.com> #11
I'm experiencing a similar issue. It doesn't make our job easier; on the contrary, it complicates things. Each of us has a different CSS writing format/layout, which makes it difficult. It's awful when it decides to arbitrarily open and then takes control away from us. After a certain point of prettifying, it just locks up. To overcome this problem, I had to resort to using a different browser. We should be able to disable this through settings. However, this setting has been removed in the latest version. It's been a nightmare for those who value orderliness.
bm...@google.com <bm...@google.com>
ap...@google.com <ap...@google.com> #12
Branch: main
commit ef23858f4bbc7b5cecce5d3db472d617482a46a1
Author: Benedikt Meurer <bmeurer@chromium.org>
Date: Tue Mar 19 08:22:21 2024
[sources] Introduce a setting to disable automatic pretty-printing.
This partially reverts
experiment as a proper setting, as there are apparently valid use cases
for disabling the automatic pretty-printing in DevTools.
Screenshot:
Fixed: b:324314570
Bug: chromium:1382752, chromium:1503031
Change-Id: Ide7e8d5214140acf9385d58db3a27ddce8518d39
Reviewed-on:
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
M front_end/panels/sources/sources-meta.ts
M front_end/testing/EnvironmentHelpers.ts
M front_end/ui/legacy/components/source_frame/SourceFrame.ts
M test/e2e/sources/can-pretty-print-sourcecode_test.ts
pe...@google.com <pe...@google.com> #13
Please answer the following questions so that we can safely process your merge request:
1. Why does your merge fit within the merge criteria for these milestones?
- Chrome Browser:
- Chrome OS:
2. What changes specifically would you like to merge? Please link to Gerrit.
3. Have the changes been released and tested on canary?
4. Is this a new feature? If yes, is it behind a Finch flag and are experiments active in any release channels?
5. [Chrome OS only]: Was the change reviewed and approved by the Eng Prod Representative?
6. If this merge addresses a major issue in the stable channel, does it require manual verification by the test team? If so, please describe required testing.
Please contact the milestone owner if you have questions.
Owners: eakpobaro (Android), eakpobaro (iOS), obenedict (ChromeOS), danielyip (Desktop)
bm...@google.com <bm...@google.com> #14
- Fix, which missed the 124 branch cut by a few hours.
https://crrev.com/c/5372061 - Yes
- No
- N/A
- N/A
da...@google.com <da...@google.com> #15
Merge approved for M124 branch, please refer to
ap...@google.com <ap...@google.com> #16
Branch: chromium/6367
commit 985d7d73c01f90b38d28ea2260e8c9ad616cdd9b
Author: Benedikt Meurer <bmeurer@chromium.org>
Date: Tue Mar 19 08:22:21 2024
[sources] Introduce a setting to disable automatic pretty-printing.
This partially reverts
experiment as a proper setting, as there are apparently valid use cases
for disabling the automatic pretty-printing in DevTools.
Screenshot:
Fixed: b:324314570
Bug: chromium:1382752, chromium:1503031
Change-Id: Ide7e8d5214140acf9385d58db3a27ddce8518d39
Reviewed-on:
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
(cherry picked from commit ef23858f4bbc7b5cecce5d3db472d617482a46a1)
Reviewed-on:
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
M front_end/panels/sources/sources-meta.ts
M front_end/testing/EnvironmentHelpers.ts
M front_end/ui/legacy/components/source_frame/SourceFrame.ts
M test/e2e/sources/can-pretty-print-sourcecode_test.ts
Description