Fixed
Status Update
Comments
ma...@chromium.org <ma...@chromium.org> #2
[Empty comment from Monorail migration]
[Deleted User] <[Deleted User]> #3
[Empty comment from Monorail migration]
ya...@google.com <ya...@google.com> #4
[Empty comment from Monorail migration]
is...@google.com <is...@google.com> #5
This issue was migrated from crbug.com/chromium/1489337?no_tracker_redirect=1
[Auto-CCs applied]
[Monorail blocking:crbug.com/chromium/465666 ]
[Monorail components added to Component Tags custom field.]
[Auto-CCs applied]
[Monorail blocking:
[Monorail components added to Component Tags custom field.]
bm...@google.com <bm...@google.com>
ap...@google.com <ap...@google.com> #6
Project: v8/v8
Branch: main
commit 1576bd328084f496150d84cb95ea0782c02064d2
Author: Eric Leese <leese@chromium.org>
Date: Fri Apr 05 17:39:48 2024
Scan for chained calls to .catch() for catch prediction
When doing catch prediction on a rejected promise assumed to be
propagating up the call stack, we check on each js frame if the
returned value is then used for chained promise methods like
.then, .finally, and .catch, and if any call in the chain is
.catch or a two-argument .then, we assume the rejection will be
caught.
Also overhauls how we scan through inlined frames and adds
tests for catch prediction in inlined call stacks.
Bug: b:40283993
Change-Id: I3b327c6823b2da3d160a237aefba3bdac96ae808
Reviewed-on:https://chromium-review.googlesource.com/c/v8/v8/+/5388436
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Eric Leese <leese@chromium.org>
Cr-Commit-Position: refs/heads/main@{#93227}
M src/execution/isolate.cc
M src/execution/isolate.h
M src/interpreter/bytecode-array-iterator.cc
M src/interpreter/bytecode-array-iterator.h
M test/cctest/test-debug.cc
M test/debugger/debug/es8/async-debug-caught-exception-cases.js
M test/inspector/debugger/break-on-exception-promise-catch-prediction-expected.txt
https://chromium-review.googlesource.com/5388436
Branch: main
commit 1576bd328084f496150d84cb95ea0782c02064d2
Author: Eric Leese <leese@chromium.org>
Date: Fri Apr 05 17:39:48 2024
Scan for chained calls to .catch() for catch prediction
When doing catch prediction on a rejected promise assumed to be
propagating up the call stack, we check on each js frame if the
returned value is then used for chained promise methods like
.then, .finally, and .catch, and if any call in the chain is
.catch or a two-argument .then, we assume the rejection will be
caught.
Also overhauls how we scan through inlined frames and adds
tests for catch prediction in inlined call stacks.
Bug: b:40283993
Change-Id: I3b327c6823b2da3d160a237aefba3bdac96ae808
Reviewed-on:
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Eric Leese <leese@chromium.org>
Cr-Commit-Position: refs/heads/main@{#93227}
M src/execution/isolate.cc
M src/execution/isolate.h
M src/interpreter/bytecode-array-iterator.cc
M src/interpreter/bytecode-array-iterator.h
M test/cctest/test-debug.cc
M test/debugger/debug/es8/async-debug-caught-exception-cases.js
M test/inspector/debugger/break-on-exception-promise-catch-prediction-expected.txt
Description
Steps to reproduce the problem:
Problem Description:
The problem is that DevTools automatically adds a closing tag and I'd like to have the option to disable that. It disrupts my typing flow.
Additional Comments:
**Chrome version: ** 105.0.0.0 **Channel: ** Stable
OS: Windows