Rqd shutdown and nimby pynput as default #1142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The shutdown process was changed to cleanly stop the process when shutdown-now is requested. Pynput is now the default mode for nimby checks and the factory builder returns NOP if the library is not installed on the environment. (cherry picked from commit 3389d0f219d599d336987ac589c9be4f0b945783)
bcipriano
approved these changes
May 10, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your change.
The shutdown process was changed to cleanly stop the process when shutdown-now is requested.
Pynput is now the default mode for nimby checks and the factory builder returns NOP if the
library is not installed on the environment.
(cherry picked from commit 3389d0f219d599d336987ac589c9be4f0b945783)
Link the Issue(s) this Pull Request is related to.
With this fix, I have not being able to reproduce #1118