Unit test scaffolding for CueJobMonitorTree and Redirect. #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregdenton
approved these changes
Apr 22, 2020
| cuegui.Style.init() | ||
|
|
||
| show_name = 'arbitrary-show-name' | ||
| job_name = 'arbitrary-job-name' |
There was a problem hiding this comment.
Slight preference: It looks like job_name is only used in the ShowGetJobWhiteboardResponse call which passes it as a list. Can we just define jobs here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link the Issue(s) this Pull Request is related to.
#396
Summarize your change.
No real test logic, but sets up the widgets and some basic data. The aim here is two-fold:
This brings CueGUI coverage 33% -> 38%.
I hope to bring this approach to other parts of the codebase in followup PRs.