-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PyOutline] Add spec_version #919
[PyOutline] Add spec_version #919
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, a couple of very minor comments.
@@ -34,6 +34,8 @@ | |||
|
|||
import six | |||
|
|||
from packaging.version import Version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: This import can be moved above the import six
line (grouping third-party imports together alphabetically)
pyoutline/tests/specver_test.py
Outdated
# limitations under the License. | ||
|
||
""" | ||
Tests for the outline.depend module. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This docstring should be updated I think.
0a2ac30
to
8401b10
Compare
addressed comments. |
Fix #918
It allows deploying clients (PyOutline) before updating Cuebot, with specifying spec_version in outline.cfg.