Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Batch Installer does not run merges if mod installation is canceled #430

Closed
Mgamerz opened this issue Jun 17, 2024 · 0 comments
Closed
Labels
bug Something isn't working Needs validation Feature is implemented and needs testing and/or feedback
Milestone

Comments

@Mgamerz
Copy link
Member

Mgamerz commented Jun 17, 2024

If mod installation is canceled in a set of batch mods, the merges that should run don't appear to be, according to the logs. They are queued as batch result instead that attach to the next shown panel. We must ensure BatchPanelResult is handled on the final close of all panels.

It might be best to build in some code to detect this and breakpoint always on it.

@Mgamerz Mgamerz added bug Something isn't working Needs validation Feature is implemented and needs testing and/or feedback labels Jun 18, 2024
@Mgamerz Mgamerz added this to the 9.0 milestone Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Needs validation Feature is implemented and needs testing and/or feedback
Projects
None yet
Development

No branches or pull requests

1 participant
  翻译: