Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split file tree logs #170

Merged
merged 3 commits into from
Aug 7, 2020
Merged

Split file tree logs #170

merged 3 commits into from
Aug 7, 2020

Conversation

PrimeSonic
Copy link
Member

@PrimeSonic PrimeSonic commented Aug 5, 2020 •
edited
Loading

  • Splits the file tree logging into a separate log entry per line
  • Uses Console.Write directly instead of Logger as we do not need to prepend all lines with meta-data
  • Solves the issue of sending in one massive log that is too big for the log buffer

@PrimeSonic PrimeSonic self-assigned this Aug 5, 2020
toebeann
toebeann requested changes Aug 6, 2020
View reviewed changes
QModManager/Patching/Patcher.cs Outdated Show resolved Hide resolved
QModManager/Utility/IOUtilities.cs Outdated Show resolved Hide resolved
QModManager/Utility/IOUtilities.cs Outdated Show resolved Hide resolved
PrimeSonic and others added 2 commits August 6, 2020 09:00
@PrimeSonic @toebeann
Update QModManager/Patching/Patcher.cs
b0b7b1c 
removing string interpolation that is no longer required

Co-authored-by: Tobey Blaber <tobey@straitjacket.software>
@PrimeSonic
- Replaces StringBuilder with direct calls to Console.Write in WriteF…
3511ff4 
…olderStructureRecursively
@PrimeSonic PrimeSonic merged commit 8afc146 into dev Aug 7, 2020
@PrimeSonic PrimeSonic deleted the SplitFileTreeLogs branch August 7, 2020 15:38
@toebeann toebeann mentioned this pull request Aug 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toebeann toebeann toebeann approved these changes

@Alexejhero Alexejhero Awaiting requested review from Alexejhero

Assignees

@PrimeSonic PrimeSonic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PrimeSonic @toebeann
  翻译：