Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging required mods #174

Merged
merged 2 commits into from
Aug 6, 2020
Merged

Fix logging required mods #174

merged 2 commits into from
Aug 6, 2020

Conversation

toebeann
Copy link
Contributor

@toebeann toebeann commented Aug 6, 2020

Updated the logging of RequiredMods with Debug Logs enabled so as not to throw errors.

Yes @PrimeSonic, I know it uses LINQ, but it also means its less code-reproduction, and its only on load, and only if Debug Logs are enabled... Take the performance cost ;)

… to throw errors. Yes @PrimeSonic, I know it uses LINQ, but it also means its less code-reproduction, and its only on load, and only if Debug Logs are enabled... Take the performance cost :P
@PrimeSonic
Copy link
Member

This code only runs at startup as we load the mods to be patched in.
I'm fine with taking a very minor performance hit in the name of cleaner code.

@toebeann toebeann merged commit dab1ad5 into dev Aug 6, 2020
@toebeann toebeann deleted the FixLoggingRequiredMods branch August 6, 2020 13:04
@toebeann toebeann mentioned this pull request Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants
  翻译: