Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix system path checks #190

Merged
merged 4 commits into from
Sep 16, 2020
Merged

Fix system path checks #190

merged 4 commits into from
Sep 16, 2020

Conversation

toebeann
Copy link
Contributor

Fixes an issue experienced by a user who had Subnautica installed in the following path: E:\Windows Steam Library\steamapps\common\Subnautica\

Caused by slightly overzealous file IO caution

Data/latest-version.txt Outdated Show resolved Hide resolved
QModManager/Patching/Patcher.cs Outdated Show resolved Hide resolved
QModPluginEmulator/QModPluginGenerator.cs Outdated Show resolved Hide resolved
Copy link
Member

@PrimeSonic PrimeSonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no reason not to include this.

@AlexejheroYTB any comments?

@Alexejhero
Copy link
Contributor

The checks were basically put in place in QMM1 when the QMods path was sometimes System32 for whatever reason. That no longer happens for another whatever reason, so the checks dont need to be there.

@toebeann toebeann merged commit cd63097 into dev Sep 16, 2020
@toebeann toebeann deleted the fix-system-path-checks branch September 16, 2020 21:15
@toebeann toebeann mentioned this pull request Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants
  翻译: