Newtonsoft patcher hotfix #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue with newtonsoft patcher.
toebeann
approved these changes
Jun 19, 2021
There was a problem hiding this comment.
Code is fine, I'm happy to move back to Finish() for the QModPluginGenerator patcher if Initialize() is causing issues. I haven't had a chance to test this and won't tonight, but I'm willing to trust Purple's testing for this and honestly, the change from Finish() -> Initialize() was never intended to stick around into the build. Mea culpa.
Should wait for @PrimeSonic to weigh in on versioning since there's been some discussion on that in the discord.
toebeann
requested changes
Jun 20, 2021
There was a problem hiding this comment.
It seems the consensus for versioning is as follows:
- When compiling internal, dev, or beta builds, bump the 4th version segment on each build
- When compiling public release builds, set the 4th version segment to zero and bump the rest accordingly
- Removing trailing
.0segments from player facing version strings such as on Nexus or installer windows
Therefore, we should drop the .0 from the .iss here. Have made suggested changes in review comments so you can easily just commit them from here.
toebeann
approved these changes
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hotfix to revert the timing change of the QModPluginGenerator that broke the Newtonsoft Patcher
Build.zip
QModManager_BZ.STABLE.zip
QModManager_SN.EXP.zip
QModManager_SN.STABLE.zip
QModManager_BZ.EXP.zip