Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error logs for invalid JSON in mod.json #248

Merged
merged 1 commit into from
Aug 22, 2021
Merged

Error logs for invalid JSON in mod.json #248

merged 1 commit into from
Aug 22, 2021

Conversation

PrimeSonic
Copy link
Member

  • Better error logs when the mod.json file contains invalid JSON
    • Adds a new ModStatus ManifestParsingError
    • Renamed the ModStatus MissingCoreInfo to MissingManifest for clarity
    • Updated relevant logs

@PrimeSonic
- Better error logs when the mod.json file contains invalid JSON
7860da0 
- Adds a new ModStatus `ManifestParsingError`
- Renamed the ModStatus `MissingCoreInfo` to `MissingManifest` for clarity
- Updated relevant logs
@PrimeSonic PrimeSonic self-assigned this Jul 13, 2021
@MrPurple6411 MrPurple6411 merged commit 3fa4fe3 into Dev Aug 22, 2021
@MrPurple6411 MrPurple6411 deleted the CatchManifestParseIssues branch August 22, 2021 19:27
@MrPurple6411 MrPurple6411 mentioned this pull request Aug 31, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrPurple6411 MrPurple6411 MrPurple6411 approved these changes

@toebeann toebeann toebeann approved these changes

@Metious Metious Metious approved these changes

@zorgesho zorgesho Awaiting requested review from zorgesho

Assignees

@PrimeSonic PrimeSonic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@PrimeSonic @MrPurple6411 @toebeann @Metious
  翻译：