Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow mods to check what game is currently running. #251

Merged
merged 2 commits into from
Aug 26, 2021
Merged

Allow mods to check what game is currently running. #251

merged 2 commits into from
Aug 26, 2021

Conversation

Esper89
Copy link
Contributor

@Esper89 Esper89 commented Aug 23, 2021

I noticed that it isn't currently possible for mods to do this without some hacky workarounds.

@PrimeSonic
Copy link
Member

Haven't seen a need for this feature, but that could just be my own lack of imagination.

The changes look fine.
Harmless at worst with potential for some modders who want to do more with using a single assembly for mogding both games.

Copy link
Member

@Metious Metious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

include the CurrentlyRunningGame property to the IQModServices interface as well so people can refer to this by doing QModServices.Main.CurrentlyRunningGame.

@Metious Metious changed the base branch from master to Dev August 23, 2021 21:53
@Esper89 Esper89 requested a review from Metious August 23, 2021 22:20
@MrPurple6411 MrPurple6411 merged commit 4ca4a8c into SubnauticaModding:Dev Aug 26, 2021
@MrPurple6411 MrPurple6411 mentioned this pull request Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants
  翻译: