-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QModManager 4.4.4 #284
Merged
QModManager 4.4.4 #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…errors Fix Nitrox dependency errors
…1.exp and BZ can use the same package. Also means that if they bring the sprite manager changes to sn1.exp then it will already be fixed.
Move Pirate checker to check first thing on load of QModLoader. Add log line if not detecting pirates too so we can tell if the line was deleted. Added QModService for checking Pirated so mods can use it to mess with pirates if they so choose. Added a special dialog for later if we ever decide to change how we work with pirates.
Adding Store Detection for Logging
PrimeSonic
approved these changes
Oct 22, 2022
toebeann
approved these changes
Oct 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, have some minor suggested changes but nothing that I would say is a showstopper.
Co-authored-by: Tobey Blaber <contact@tobey.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made in this PR
PRs associated:
Builds