Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QModManager 4.4.4 #284

Merged
merged 40 commits into from
Oct 31, 2022
Merged

QModManager 4.4.4 #284

merged 40 commits into from
Oct 31, 2022

Conversation

Metious
Copy link
Member

@Metious Metious commented Oct 20, 2022

toebeann and others added 30 commits April 1, 2022 01:40
…1.exp and BZ can use the same package.

Also means that if they bring the sprite manager changes to sn1.exp then it will already be fixed.
Move Pirate checker to check first thing on load of QModLoader.
Add log line if not detecting pirates too so we can tell if the line was deleted.
Added QModService for checking Pirated so mods can use it to mess with pirates if they so choose.

Added a special dialog for later if we ever decide to change how we work with pirates.
Adding Store Detection for Logging
Copy link
Contributor

@toebeann toebeann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, have some minor suggested changes but nothing that I would say is a showstopper.

QModManager/HarmonyPatches/MaskTelemetryLogging.cs Outdated Show resolved Hide resolved
QModManager/Patching/Patcher.cs Show resolved Hide resolved
QModManager/Patching/StoreDetector.cs Outdated Show resolved Hide resolved
QModManager/Utility/Dialog.cs Show resolved Hide resolved
Metious and others added 2 commits October 31, 2022 20:37
Co-authored-by: Tobey Blaber <contact@tobey.me>
@Metious Metious merged commit dc72b39 into master Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants
  翻译: