Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Lua doc for RegisterHook to accurately state how the callback params work #372

Merged
merged 2 commits into from
Feb 10, 2024

Conversation

UE4SS
Copy link
Collaborator

@UE4SS UE4SS commented Feb 9, 2024

No description provided.

Copy link
Member

@Buckminsterfullerene02 Buckminsterfullerene02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't "native/non BP" be /Script/ and vice versa? Or at least mention that at the top. Remember that a lot of people following these dibs have no knowledge of ue so aren't nearly as likely to understand what these are than mapping them directly to how their string "looks"

@UE4SS
Copy link
Collaborator Author

UE4SS commented Feb 9, 2024

Shouldn't "native/non BP" be /Script/ and vice versa? Or at least mention that at the top. Remember that a lot of people following these dibs have no knowledge of ue so aren't nearly as likely to understand what these are than mapping them directly to how their string "looks"

The problem is, I don't know if a function starting with /Script/ is guaranteed to be native, and that not starting with /Script/ guarantees that it's non-native.
If you can tell me that this is the case, then I'll change it.

@Buckminsterfullerene02
Copy link
Member

Native is always /Script/
Packages can either be /Engine/ for engine content or /Game/ for game content

@Buckminsterfullerene02 Buckminsterfullerene02 merged commit 3a381a6 into main Feb 10, 2024
@Buckminsterfullerene02 Buckminsterfullerene02 deleted the lua-docs-registerhook branch February 10, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants
  翻译: