Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more sensors like CPU and GPU temperatures and usage #1858

Merged
merged 11 commits into from
Jan 11, 2020
Merged

Added more sensors like CPU and GPU temperatures and usage #1858

merged 11 commits into from
Jan 11, 2020

Conversation

diogotr7
Copy link
Collaborator

List any issues that this PR fixes: fixes # , etc...

This pull request proposes the following changes:

  • Added HardwareMonitor in Utils
  • This Utility can start and stop updating information on a per hardware basis based on if it is being accessed or not
  • Added CPU, GPU, and RAM nodes to LocalPCInfo with useful variables

Known issues/To do:

  • Some of the variables will be 0 opn some systems because not every hardware has every sensor
  • Had to leave the old CPUUsage and Memory variables to not break profiules. Maybe could remove them and just change the path when loading old profiles?
  • Can cause some cpu usage on nvidia optimus systems when reading gpu data. This issue doesnt happen if the gpu is being used, such as when playing a game. I don't know if there is a way to detect this.
  • Maybe some place in the UI to choose the update rate of each hardware? Would appreciate ideas.

@xQwexx
Copy link
Contributor

xQwexx commented Jan 3, 2020

I think this is going to fix #68 , #149 , #469 ,
and if it was the incorrect reading then #1609

@diogotr7 diogotr7 merged commit 0829b2f into antonpup:dev Jan 11, 2020
@diogotr7 diogotr7 deleted the feature/librehardwaremonitor branch January 11, 2020 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants
  翻译: