Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ducky Keyboard Support #1892

Merged
merged 13 commits into from
Feb 22, 2020
Merged

Ducky Keyboard Support #1892

merged 13 commits into from
Feb 22, 2020

Conversation

Lexevolution
Copy link
Contributor

@Lexevolution Lexevolution commented Jan 23, 2020 •
edited
Loading

List any issues that this PR fixes: fixes # , etc...

Fixes #1391

This pull request proposes the following changes:

  • Adds these Ducky keyboards:
    • Ducky Shine 7
    • Ducky One 2 RGB
    • Ducky One 2 RGB TKL

Known issues/To do:

  • This does NOT include support for the Ducky One 2 Mini. That keyboard can never be supported due to there being no rgb communication between the keyboard and the PC.

@Lexevolution
Copy link
Contributor Author

Lexevolution commented Feb 2, 2020 •
edited
Loading

I've added ISO support now. Just need someone to test. It's difficult finding someone with this keyboard that has the ISO layout, since almost everyone has the ANSI one... 99% sure it's correct though.

diogotr7
diogotr7 previously approved these changes Feb 8, 2020
View reviewed changes
@Lexevolution Lexevolution changed the title Ducky Shine 7 Keyboard Support Ducky Keyboard Support Feb 16, 2020
@diogotr7 diogotr7 merged commit cf168fe into antonpup:dev Feb 22, 2020
@Lexevolution Lexevolution deleted the feature/ducky-shine-7-support branch February 23, 2020 03:36
@Lexevolution Lexevolution restored the feature/ducky-shine-7-support branch February 23, 2020 03:36
@Lexevolution Lexevolution deleted the feature/ducky-shine-7-support branch February 23, 2020 03:41
@diogotr7 diogotr7 mentioned this pull request Feb 25, 2020
Closed
@xQwexx xQwexx mentioned this pull request Mar 12, 2020
Open
16 tasks
@mikk150 mikk150 mentioned this pull request Apr 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diogotr7 diogotr7 diogotr7 approved these changes

@Wibble199 Wibble199 Awaiting requested review from Wibble199

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lexevolution @Wibble199 @diogotr7
  翻译：