Automatic profile and layer detection #1979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should've been done long ago.
…should've been done long ago.
…UI related purposes. This means that a dummy layer does not have to be created to get the ID anymore. Also changed how layer handlers are stored and therefore how an application's custom layers are registered. They are now automatically picked up, and added to the global registration but are set as non-default. In the application config, the line `AllowLayer<TypeOfLayerHandler>();` should be added.
…-layer-registration
Also removed redundant class.
…-layer-registration
Made default layer appear at the top of the list.
diogotr7
approved these changes
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so that application profiles and layers are automatically registered by the LightingStateManager instead of needing to be manually done.
Profiles.Applicationwill be registered as a profile.ILayerHandlerwill be registered as a layer.LayerHandlerMetaattribute will automatically use the default settings:Aurora.Settings.Layersnamespace. Anything not in the namespace is assumed to be a application-specific layer and will still be registered but will not be a default layer. Applications wishing to allow a non-default layer should now use the newAllowLayer<T>method in the application config.