Add correct signatures for operators in google provider package (#10144)

apache · Aug 4, 2020 · 1437cb7 · 1437cb7
1 parent 73a08ed
commit 1437cb7
Show file tree

Hide file tree

Showing 42 changed files with 381 additions and 357 deletions.
diff --git a/airflow/providers/google/ads/operators/ads.py b/airflow/providers/google/ads/operators/ads.py
@@ -63,7 +63,7 @@ class GoogleAdsListAccountsOperator(BaseOperator):
 
     @apply_defaults
     def __init__(
-        self,
+        self, *,
         bucket: str,
         object_name: str,
         gcp_conn_id: str = "google_cloud_default",

diff --git a/airflow/providers/google/cloud/operators/automl.py b/airflow/providers/google/cloud/operators/automl.py
@@ -64,7 +64,7 @@ class AutoMLTrainModelOperator(BaseOperator):
 
     @apply_defaults
     def __init__(
-        self,
+        self, *,
         model: dict,
         location: str,
         project_id: Optional[str] = None,
@@ -138,7 +138,7 @@ class AutoMLPredictOperator(BaseOperator):
 
     @apply_defaults
     def __init__(
-        self,
+        self, *,
         model_id: str,
         location: str,
         payload: dict,
@@ -230,7 +230,7 @@ class AutoMLBatchPredictOperator(BaseOperator):
 
     @apply_defaults
     def __init__(  # pylint: disable=too-many-arguments
-        self,
+        self, *,
         model_id: str,
         input_config: dict,
         output_config: dict,
@@ -309,7 +309,7 @@ class AutoMLCreateDatasetOperator(BaseOperator):
 
     @apply_defaults
     def __init__(
-        self,
+        self, *,
         dataset: dict,
         location: str,
         project_id: Optional[str] = None,
@@ -384,7 +384,7 @@ class AutoMLImportDataOperator(BaseOperator):
 
     @apply_defaults
     def __init__(
-        self,
+        self, *,
         dataset_id: str,
         location: str,
         input_config: dict,
@@ -474,7 +474,7 @@ class AutoMLTablesListColumnSpecsOperator(BaseOperator):
 
     @apply_defaults
     def __init__(  # pylint: disable=too-many-arguments
-        self,
+        self, *,
         dataset_id: str,
         table_spec_id: str,
         location: str,
@@ -556,7 +556,7 @@ class AutoMLTablesUpdateDatasetOperator(BaseOperator):
 
     @apply_defaults
     def __init__(
-        self,
+        self, *,
         dataset: dict,
         location: str,
         update_mask: Optional[dict] = None,
@@ -623,7 +623,7 @@ class AutoMLGetModelOperator(BaseOperator):
 
     @apply_defaults
     def __init__(
-        self,
+        self, *,
         model_id: str,
         location: str,
         project_id: Optional[str] = None,
@@ -689,7 +689,7 @@ class AutoMLDeleteModelOperator(BaseOperator):
 
     @apply_defaults
     def __init__(
-        self,
+        self, *,
         model_id: str,
         location: str,
         project_id: Optional[str] = None,
@@ -765,7 +765,7 @@ class AutoMLDeployModelOperator(BaseOperator):
 
     @apply_defaults
     def __init__(
-        self,
+        self, *,
         model_id: str,
         location: str,
         project_id: Optional[str] = None,
@@ -844,7 +844,7 @@ class AutoMLTablesListTableSpecsOperator(BaseOperator):
 
     @apply_defaults
     def __init__(
-        self,
+        self, *,
         dataset_id: str,
         location: str,
         page_size: Optional[int] = None,
@@ -915,7 +915,7 @@ class AutoMLListDatasetOperator(BaseOperator):
 
     @apply_defaults
     def __init__(
-        self,
+        self, *,
         location: str,
         project_id: Optional[str] = None,
         metadata: Optional[MetaData] = None,
@@ -985,7 +985,7 @@ class AutoMLDeleteDatasetOperator(BaseOperator):
 
     @apply_defaults
     def __init__(
-        self,
+        self, *,
         dataset_id: Union[str, List[str]],
         location: str,
         project_id: Optional[str] = None,

diff --git a/airflow/providers/google/cloud/operators/bigquery.py b/airflow/providers/google/cloud/operators/bigquery.py
@@ -141,7 +141,7 @@ class BigQueryCheckOperator(CheckOperator):
 
     @apply_defaults
     def __init__(
-        self,
+        self, *,
         sql: str,
         gcp_conn_id: str = 'google_cloud_default',
         bigquery_conn_id: Optional[str] = None,
@@ -196,7 +196,7 @@ class BigQueryValueCheckOperator(ValueCheckOperator):
 
     @apply_defaults
     def __init__(
-        self,
+        self, *,
         sql: str,
         pass_value: Any,
         tolerance: Any = None,
@@ -270,7 +270,7 @@ class BigQueryIntervalCheckOperator(IntervalCheckOperator):
 
     @apply_defaults
     def __init__(
-        self,
+        self, *,
         table: str,
         metrics_thresholds: dict,
         date_filter_column: str = 'ds',
@@ -364,7 +364,7 @@ class BigQueryGetDataOperator(BaseOperator):
 
     @apply_defaults
     def __init__(
-        self,
+        self, *,
         dataset_id: str,
         table_id: str,
         max_results: int = 100,
@@ -528,6 +528,7 @@ def operator_extra_links(self):
     # pylint: disable=too-many-arguments, too-many-locals
     @apply_defaults
     def __init__(self,
+                 *,
                  sql: Union[str, Iterable],
                  destination_dataset_table: Optional[str] = None,
                  write_disposition: Optional[str] = 'WRITE_EMPTY',
@@ -783,7 +784,7 @@ class BigQueryCreateEmptyTableOperator(BaseOperator):
     # pylint: disable=too-many-arguments
     @apply_defaults
     def __init__(
-        self,
+        self, *,
         dataset_id: str,
         table_id: str,
         table_resource: Optional[Dict[str, Any]] = None,
@@ -962,7 +963,7 @@ class BigQueryCreateExternalTableOperator(BaseOperator):
     # pylint: disable=too-many-arguments,too-many-locals
     @apply_defaults
     def __init__(
-        self,
+        self, *,
         bucket: str,
         source_objects: List,
         destination_project_dataset_table: str,
@@ -1130,7 +1131,7 @@ class BigQueryDeleteDatasetOperator(BaseOperator):
 
     @apply_defaults
     def __init__(
-        self,
+        self, *,
         dataset_id: str,
         project_id: Optional[str] = None,
         delete_contents: bool = False,
@@ -1210,6 +1211,7 @@ class BigQueryCreateEmptyDatasetOperator(BaseOperator):
 
     @apply_defaults
     def __init__(self,
+                 *,
                  dataset_id: Optional[str] = None,
                  project_id: Optional[str] = None,
                  dataset_reference: Optional[Dict] = None,
@@ -1279,6 +1281,7 @@ class BigQueryGetDatasetOperator(BaseOperator):
 
     @apply_defaults
     def __init__(self,
+                 *,
                  dataset_id: str,
                  project_id: Optional[str] = None,
                  gcp_conn_id: str = 'google_cloud_default',
@@ -1329,7 +1332,7 @@ class BigQueryGetDatasetTablesOperator(BaseOperator):
 
     @apply_defaults
     def __init__(
-        self,
+        self, *,
         dataset_id: str,
         project_id: Optional[str] = None,
         max_results: Optional[int] = None,
@@ -1386,7 +1389,7 @@ class BigQueryPatchDatasetOperator(BaseOperator):
 
     @apply_defaults
     def __init__(
-        self,
+        self, *,
         dataset_id: str,
         dataset_resource: dict,
         project_id: Optional[str] = None,
@@ -1453,7 +1456,7 @@ class BigQueryUpdateDatasetOperator(BaseOperator):
 
     @apply_defaults
     def __init__(
-        self,
+        self, *,
         dataset_resource: dict,
         fields: Optional[List[str]] = None,
         dataset_id: Optional[str] = None,
@@ -1518,7 +1521,7 @@ class BigQueryDeleteTableOperator(BaseOperator):
 
     @apply_defaults
     def __init__(
-        self,
+        self, *,
         deletion_dataset_table: str,
         gcp_conn_id: str = 'google_cloud_default',
         bigquery_conn_id: Optional[str] = None,
@@ -1589,7 +1592,7 @@ class BigQueryUpsertTableOperator(BaseOperator):
 
     @apply_defaults
     def __init__(
-        self,
+        self, *,
         dataset_id: str,
         table_resource: dict,
         project_id: Optional[str] = None,

diff --git a/airflow/providers/google/cloud/operators/bigquery_dts.py b/airflow/providers/google/cloud/operators/bigquery_dts.py
@@ -66,7 +66,7 @@ class BigQueryCreateDataTransferOperator(BaseOperator):
 
     @apply_defaults
     def __init__(
-        self,
+        self, *,
         transfer_config: dict,
         project_id: Optional[str] = None,
         authorization_code: Optional[str] = None,
@@ -132,7 +132,7 @@ class BigQueryDeleteDataTransferConfigOperator(BaseOperator):
 
     @apply_defaults
     def __init__(
-        self,
+        self, *,
         transfer_config_id: str,
         project_id: Optional[str] = None,
         retry: Retry = None,
@@ -208,7 +208,7 @@ class BigQueryDataTransferServiceStartTransferRunsOperator(BaseOperator):
 
     @apply_defaults
     def __init__(
-        self,
+        self, *,
         transfer_config_id: str,
         project_id: Optional[str] = None,
         requested_time_range: Optional[dict] = None,

diff --git a/airflow/providers/google/cloud/operators/bigtable.py b/airflow/providers/google/cloud/operators/bigtable.py
@@ -94,7 +94,7 @@ class BigtableCreateInstanceOperator(BaseOperator, BigtableValidationMixin):
     template_fields: Iterable[str] = ['project_id', 'instance_id', 'main_cluster_id', 'main_cluster_zone']
 
     @apply_defaults
-    def __init__(self,  # pylint: disable=too-many-arguments
+    def __init__(self, *,   # pylint: disable=too-many-arguments
                  instance_id: str,
                  main_cluster_id: str,
                  main_cluster_zone: str,
@@ -181,7 +181,7 @@ class BigtableDeleteInstanceOperator(BaseOperator, BigtableValidationMixin):
     template_fields = ['project_id', 'instance_id']  # type: Iterable[str]
 
     @apply_defaults
-    def __init__(self,
+    def __init__(self, *,
                  instance_id: str,
                  project_id: Optional[str] = None,
                  gcp_conn_id: str = 'google_cloud_default',
@@ -241,7 +241,7 @@ class BigtableCreateTableOperator(BaseOperator, BigtableValidationMixin):
     template_fields = ['project_id', 'instance_id', 'table_id']  # type: Iterable[str]
 
     @apply_defaults
-    def __init__(self,
+    def __init__(self, *,
                  instance_id: str,
                  table_id: str,
                  project_id: Optional[str] = None,
@@ -331,7 +331,7 @@ class BigtableDeleteTableOperator(BaseOperator, BigtableValidationMixin):
     template_fields = ['project_id', 'instance_id', 'table_id']  # type: Iterable[str]
 
     @apply_defaults
-    def __init__(self,
+    def __init__(self, *,
                  instance_id: str,
                  table_id: str,
                  project_id: Optional[str] = None,
@@ -396,7 +396,7 @@ class BigtableUpdateClusterOperator(BaseOperator, BigtableValidationMixin):
     template_fields = ['project_id', 'instance_id', 'cluster_id', 'nodes']  # type: Iterable[str]
 
     @apply_defaults
-    def __init__(self,
+    def __init__(self, *,
                  instance_id: str,
                  cluster_id: str,
                  nodes: int,

diff --git a/airflow/providers/google/cloud/operators/cloud_build.py b/airflow/providers/google/cloud/operators/cloud_build.py
@@ -184,7 +184,7 @@ class CloudBuildCreateBuildOperator(BaseOperator):
     template_ext = ['.yml', '.yaml', '.json']
 
     @apply_defaults
-    def __init__(self,
+    def __init__(self, *,
                  body: Union[dict, str],
                  project_id: Optional[str] = None,
                  gcp_conn_id: str = "google_cloud_default",