Skip to content

Commit

Permalink
Fix assignment of template field in __init__ in custom_job (#36789)
Browse files Browse the repository at this point in the history
* Fix assignment of template field in __init__ in vertex_ai

* remove file from exclude
  • Loading branch information
romsharon98 authored Feb 7, 2024
1 parent 12ad7be commit 7883bcc
Show file tree
Hide file tree
Showing 2 changed files with 33 additions and 4 deletions.
1 change: 0 additions & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,6 @@ repos:
^airflow\/providers\/google\/cloud\/transfers\/bigquery_to_mysql\.py$|
^airflow\/providers\/amazon\/aws\/transfers\/redshift_to_s3\.py$|
^airflow\/providers\/google\/cloud\/operators\/compute\.py$|
^airflow\/providers\/google\/cloud\/operators\/vertex_ai\/custom_job\.py$|
^airflow\/providers\/amazon\/aws\/operators\/emr\.py$|
^airflow\/providers\/amazon\/aws\/operators\/eks\.py$
)$
Expand Down
36 changes: 33 additions & 3 deletions airflow/providers/google/cloud/operators/vertex_ai/custom_job.py
Original file line number Diff line number Diff line change
Expand Up @@ -445,9 +445,19 @@ def __init__(
self,
*,
command: Sequence[str] = [],
region: str,
parent_model: str | None = None,
impersonation_chain: str | Sequence[str] | None = None,
dataset_id: str | None = None,
**kwargs,
) -> None:
super().__init__(**kwargs)
super().__init__(
region=region,
parent_model=parent_model,
impersonation_chain=impersonation_chain,
dataset_id=dataset_id,
**kwargs,
)
self.command = command

def execute(self, context: Context):
Expand Down Expand Up @@ -816,9 +826,19 @@ def __init__(
*,
python_package_gcs_uri: str,
python_module_name: str,
region: str,
parent_model: str | None = None,
impersonation_chain: str | Sequence[str] | None = None,
dataset_id: str | None = None,
**kwargs,
) -> None:
super().__init__(**kwargs)
super().__init__(
region=region,
parent_model=parent_model,
impersonation_chain=impersonation_chain,
dataset_id=dataset_id,
**kwargs,
)
self.python_package_gcs_uri = python_package_gcs_uri
self.python_module_name = python_module_name

Expand Down Expand Up @@ -1190,9 +1210,19 @@ def __init__(
*,
script_path: str,
requirements: Sequence[str] | None = None,
region: str,
parent_model: str | None = None,
impersonation_chain: str | Sequence[str] | None = None,
dataset_id: str | None = None,
**kwargs,
) -> None:
super().__init__(**kwargs)
super().__init__(
region=region,
parent_model=parent_model,
impersonation_chain=impersonation_chain,
dataset_id=dataset_id,
**kwargs,
)
self.requirements = requirements
self.script_path = script_path

Expand Down

0 comments on commit 7883bcc

Please sign in to comment.
  翻译: