Skip to content

Commit

Permalink
Improve setUp/tearDown in Cloud Firestore system test (#7862)
Browse files Browse the repository at this point in the history
  • Loading branch information
mik-laj committed Mar 26, 2020
1 parent 4e9a7d0 commit e3920f1
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
4. Grant Firebase admin account permissions to manage BigQuery. This is required to create a dataset.
5. Create a bucket in Firebase project and
6. Give read/write access for Firebase admin to bucket to step no. 5.
7. Create collection in the Firestore database.
"""

import os
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ def tearDown(self):
def clean_up(self):
self.execute_with_ctx(["gsutil", "rm", "-r", f"{EXPORT_DESTINATION_URL}"], G_FIREBASE_KEY)
self.execute_with_ctx(
["bq", "rm", f"{self._project_id()}:{DATASET_NAME}"], G_FIREBASE_KEY
["bq", "rm", '--force', '--recursive', f"{self._project_id()}:{DATASET_NAME}"], G_FIREBASE_KEY
)

@provide_gcp_context(G_FIREBASE_KEY)
Expand Down

0 comments on commit e3920f1

Please sign in to comment.
  翻译: