Prevent scheduler crash when serialized dag is missing #19113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scheduler._send_dag_callbacks_to_processor calls dag_run.get_dag which raises exception. This PR changes to calling dagbag.get_dag and changing Scheduler._send_dag_callbacks_to_processor args to accept dag instead of dag_run.
potiuk
approved these changes
Oct 20, 2021
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
jedcunningham
approved these changes
Oct 20, 2021
jedcunningham
pushed a commit
that referenced
this pull request
Oct 20, 2021
Scheduler._send_dag_callbacks_to_processor calls dag_run.get_dag which raises exception. This PR changes to calling dagbag.get_dag and changing Scheduler._send_dag_callbacks_to_processor args to accept dag instead of dag_run. (cherry picked from commit 5dc375a)
2 tasks
jedcunningham
pushed a commit
to astronomer/airflow
that referenced
this pull request
Oct 26, 2021
Scheduler._send_dag_callbacks_to_processor calls dag_run.get_dag which raises exception. This PR changes to calling dagbag.get_dag and changing Scheduler._send_dag_callbacks_to_processor args to accept dag instead of dag_run. (cherry picked from commit 5dc375a)
sharon2719
pushed a commit
to sharon2719/airflow
that referenced
this pull request
Oct 27, 2021
Scheduler._send_dag_callbacks_to_processor calls dag_run.get_dag which raises exception. This PR changes to calling dagbag.get_dag and changing Scheduler._send_dag_callbacks_to_processor args to accept dag instead of dag_run.
37 tasks
jedcunningham
pushed a commit
to astronomer/airflow
that referenced
this pull request
Oct 27, 2021
Scheduler._send_dag_callbacks_to_processor calls dag_run.get_dag which raises exception. This PR changes to calling dagbag.get_dag and changing Scheduler._send_dag_callbacks_to_processor args to accept dag instead of dag_run. (cherry picked from commit 5dc375a)
Closed
2 tasks
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Feb 3, 2022
Cherry-pick from community: apache/airflow#18554 and apache/airflow#19113 and apache/airflow#18523 Change-Id: If366bd0ec34d96f736b84c45b18305785dc6e671 GitOrigin-RevId: 3cb294ecbee35e49817880ba95db4467471e5029
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scheduler._send_dag_callbacks_to_processor calls dag_run.get_dag which
raises exception. This PR changes to calling dagbag.get_dag and changing
Scheduler._send_dag_callbacks_to_processor args to accept dag instead of dag_run.
Closes: #18843
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.