Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use object instead of array in config.yml for config template #28417

Merged
merged 5 commits into from
Dec 20, 2022
Merged

Use object instead of array in config.yml for config template #28417

merged 5 commits into from
Dec 20, 2022

Conversation

dstandish
Copy link
Contributor

@dstandish dstandish commented Dec 16, 2022 •
edited
Loading

This makes it easier to navigate the document in IDE.

After:
image

Before:
image

@boring-cyborg boring-cyborg bot added area:dev-tools area:providers provider:google Google (including GCP) related issues labels Dec 16, 2022
@dstandish dstandish force-pushed the use-struct-not-sequence-in-config-yml branch from 20839a7 to 1e170d6 Compare December 20, 2022 18:44
@dstandish
Copy link
Contributor Author

hi @potiuk , this is a small quality of life improvement making the yaml more easily navigable with tooling

potiuk
potiuk approved these changes Dec 20, 2022
View reviewed changes
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh absolutely :)

@dstandish dstandish merged commit 820f5a9 into apache:main Dec 20, 2022
@dstandish dstandish deleted the use-struct-not-sequence-in-config-yml branch December 20, 2022 21:17
@eladkal eladkal mentioned this pull request Jan 2, 2023
Closed
84 tasks
@pierrejeambrun pierrejeambrun added this to the Airflow 2.6.0 milestone Jan 9, 2023
@pierrejeambrun pierrejeambrun mentioned this pull request Mar 18, 2023
Merged
@ephraimbuddy ephraimbuddy added the type:improvement Changelog: Improvements label Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potiuk potiuk potiuk approved these changes

@ashb ashb Awaiting requested review from ashb ashb is a code owner

@mik-laj mik-laj Awaiting requested review from mik-laj

@turbaszek turbaszek Awaiting requested review from turbaszek

@jedcunningham jedcunningham Awaiting requested review from jedcunningham jedcunningham is a code owner

@kaxil kaxil Awaiting requested review from kaxil

Assignees
No one assigned
Labels
area:dev-tools area:providers provider:google Google (including GCP) related issues type:improvement Changelog: Improvements
Projects
None yet
Milestone
Airflow 2.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@dstandish @potiuk @ephraimbuddy @pierrejeambrun
  翻译：