Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix the default dependency installation error #1363

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

yyhhyyyyyy
Copy link
Contributor

Description

Fixed the issue where some users were unable to install dependencies properly using pip install -e ".[default]", and updated some dependencies to be installed via the PyPI channel.

If users wish to complete the usage of the quantitative library, they should execute pip install -e ".[bitsandbytes]", but please ensure that it is done under conditions where network connectivity is supported.

How Has This Been Tested?

pip install -e ".[default]"

Snapshots:

Here is the successful screenshot of executing pip install -e ".[default]":
image

Here is the successful screenshot of executing pip install -e ".[bitsandbytes]":
image

Checklist:

  • My code follows the style guidelines of this project
  • I have already rebased the commits and make the commit message conform to the project standard.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules

@yyhhyyyyyy yyhhyyyyyy changed the title Fixed the default dependency installation error. #1360 Fixed the default dependency installation error. Apr 1, 2024
@Aries-ckt
Copy link
Collaborator

hi, @hui824 thanks for your pr, /assign @fangyinc

Reformatted the code.
@fangyinc fangyinc changed the title Fixed the default dependency installation error. fix: Fix the default dependency installation error Apr 2, 2024
@github-actions github-actions bot added the fix Bug fixes label Apr 2, 2024
Copy link
Collaborator

@fangyinc fangyinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Collaborator

@Aries-ckt Aries-ckt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@Aries-ckt Aries-ckt merged commit 62f90c9 into eosphoros-ai:main Apr 2, 2024
3 checks passed
Hopshine pushed a commit to Hopshine/DB-GPT that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
  翻译: