Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix parameter type mismatch issue when using Milvus #1449

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

jsRuner
Copy link
Contributor

@jsRuner jsRuner commented Apr 23, 2024

Description

Fix parameter type mismatch issue when using Milvus

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Snapshots:

Include snapshots for easier review.

Checklist:

  • My code follows the style guidelines of this project
  • I have already rebased the commits and make the commit message conform to the project standard.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules

@csunny
Copy link
Collaborator

csunny commented Apr 24, 2024

@jsRuner Hi, Can you give the bug or error detail information?

@jsRuner
Copy link
Contributor Author

jsRuner commented Apr 25, 2024

@jsRuner Hi, Can you give the bug or error detail information?

When in a knowledge base conversation, use the configuration VECTOR_STORE.TYPE=Milvus
This problem will arise. The log is as follows

File "/Users/wuwenfu/workspace/python/DB-GPT/dbgpt/storage/vector_store/milvus_store.py", line 448, in similar_search_with_scores docs_and_scores = [ File "/Users/wuwenfu/workspace/python/DB-GPT/dbgpt/storage/vector_store/milvus_store.py", line 449, in <listcomp> Chunk( File "/Users/wuwenfu/anaconda3/envs/dbgpt_env/lib/python3.10/site-packages/pydantic/main.py", line 175, in __init__ self.__pydantic_validator__.validate_python(data, self_instance=self) pydantic_core._pydantic_core.ValidationError: 1 validation error for Chunk chunk_id Input should be a valid string [type=string_type, input_value=448558551467296374, input_type=int] For further information visit https://errors.pydantic.dev/2.7/v/string_type

Copy link
Collaborator

@Aries-ckt Aries-ckt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@fangyinc fangyinc changed the title Fix parameter type mismatch issue when using Milvus fix: Fix parameter type mismatch issue when using Milvus Apr 26, 2024
@github-actions github-actions bot added the fix Bug fixes label Apr 26, 2024
Copy link
Collaborator

@fangyinc fangyinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@fangyinc fangyinc merged commit 26eb200 into eosphoros-ai:main Apr 26, 2024
6 checks passed
@jsRuner jsRuner deleted the fix-Milvus branch April 29, 2024 07:06
Hopshine pushed a commit to Hopshine/DB-GPT that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
  翻译: