Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core[patch]: Add ruff rule UP006(use PEP585 annotations) #26574

Merged
merged 3 commits into from
Sep 17, 2024
Merged

core[patch]: Add ruff rule UP006(use PEP585 annotations) #26574

merged 3 commits into from
Sep 17, 2024

Conversation

cbornet
Copy link
Collaborator

@cbornet cbornet commented Sep 17, 2024 •
edited
Loading

  • Added rules UPD006 now that Pydantic is v2+

@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Sep 17, 2024
@vercel Vercel
Copy link

vercel bot commented Sep 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Sep 17, 2024 9:22pm

@dosubot dosubot bot added the Ɑ: core Related to langchain-core label Sep 17, 2024
@cbornet cbornet force-pushed the ruff-core-fa branch 5 times, most recently from 9924116 to 5241b5f Compare September 17, 2024 16:33
@cbornet cbornet changed the title Add ruff FA(future anotations) rules Add ruff rule UP006(use PEP585 annotations) Sep 17, 2024
@eyurtsev eyurtsev self-assigned this Sep 17, 2024
@eyurtsev eyurtsev changed the title Add ruff rule UP006(use PEP585 annotations) core[patch]: Add ruff rule UP006(use PEP585 annotations) Sep 17, 2024
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Sep 17, 2024
@eyurtsev eyurtsev enabled auto-merge (squash) September 17, 2024 21:19
@eyurtsev eyurtsev merged commit 3a99467 into langchain-ai:master Sep 17, 2024
98 checks passed
@cbornet cbornet deleted the ruff-core-fa branch September 18, 2024 06:02
Sheepsta300 pushed a commit to Sheepsta300/langchain that referenced this pull request Oct 1, 2024
@cbornet @eyurtsev @Sheepsta300
core[patch]: Add ruff rule UP006(use PEP585 annotations) (langchain-a…
eb5785e 
…i#26574)

* Added rules `UPD006` now that Pydantic is v2+

---------

Co-authored-by: Eugene Yurtsev <eyurtsev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyurtsev eyurtsev eyurtsev approved these changes

Assignees

@eyurtsev eyurtsev

Labels
Ɑ: core Related to langchain-core lgtm PR looks good. Use to confirm that a PR is ready for merging. size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
PR Reviews
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cbornet @eyurtsev
  翻译：