core: Put Python version as a project requirement so it is considered by ruff #26608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
a892fb3
to
195cadd
Compare
195cadd
to
798a763
Compare
eyurtsev
approved these changes
Sep 18, 2024
|
reverting the pyproject change because core isn't installable by I think if we completely switch metadata over to project from tool.poetry that will help, but docs build currently can't run I think extended tests pass because none of the uv install steps actually install core - they just affect envs that have core already installed from poetry |
This was referenced Sep 18, 2024
Sheepsta300
pushed a commit
to Sheepsta300/langchain
that referenced
this pull request
Oct 1, 2024
… by ruff (langchain-ai#26608) Ruff doesn't know about the python version in `[tool.poetry.dependencies]`. It can get it from `project.requires-python`. Notes: * poetry seems to have issues getting the python constraints from `requires-python` and using `python` in per dependency constraints. So I had to duplicate the info. I will open an issue on poetry. * `inspect.isclass()` doesn't work correctly with `GenericAlias` (`list[...]`, `dict[..., ...]`) on Python <3.11 so I added some `not isinstance(type, GenericAlias)` checks: Python 3.11 ```pycon >>> import inspect >>> inspect.isclass(list) True >>> inspect.isclass(list[str]) False ``` Python 3.9 ```pycon >>> import inspect >>> inspect.isclass(list) True >>> inspect.isclass(list[str]) True ``` Co-authored-by: Eugene Yurtsev <eyurtsev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruff doesn't know about the python version in
[tool.poetry.dependencies]. It can get it fromproject.requires-python.Notes:
requires-pythonand usingpythonin per dependency constraints. So I had to duplicate the info. I will open an issue on poetry.inspect.isclass()doesn't work correctly withGenericAlias(list[...],dict[..., ...]) on Python <3.11 so I added somenot isinstance(type, GenericAlias)checks:Python 3.11
Python 3.9