core: Run LangChainTracer inline #26797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
nfcampos
commented
Sep 24, 2024
•
- this flag ensures the tracer always runs in the same thread as the run being traced for both sync and async runs
- pro: less chance for ordering bugs and other oddities
- blocking the event loop is not a concern given all code in the tracer holds the GIL anyway
- this flag ensures the tracer always runs in the same thread as the run being traced for both sync and async runs - pro: less chance for ordering bugs and other oddities - blocking the event loop is not a concern given all code in the tracer holds the GIL anyway
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
hinthornw
approved these changes
Sep 24, 2024
|
Aren't there network requests being done which would result in the gil being released? |
|
The langchain tracer doesn't make any network requests inline |
|
Got it -- won't hurt to add a doc-string in run_inline explaining why that's OK. Knowing that this is OK depends on understanding what's happening inside the langsmith client |
Sheepsta300
pushed a commit
to Sheepsta300/langchain
that referenced
this pull request
Oct 1, 2024
- this flag ensures the tracer always runs in the same thread as the run being traced for both sync and async runs - pro: less chance for ordering bugs and other oddities - blocking the event loop is not a concern given all code in the tracer holds the GIL anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.