Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: fix: using async rate limiter methods in async code #26914

Merged

Conversation

esciara
Copy link
Contributor

@esciara esciara commented Sep 26, 2024

Description: Replaced blocking (sync) rate_limiter code in async methods.

Issue: #26913

Dependencies: N/A

Twitter handle: no need 🤗

Copy link

vercel bot commented Sep 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2024 8:37pm

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. Ɑ: core Related to langchain-core 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature labels Sep 26, 2024
@esciara esciara force-pushed the fix-blocking-rate-limiting-in-async-code branch from be2b2d6 to df2f8da Compare September 26, 2024 20:36
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Sep 26, 2024
@eyurtsev eyurtsev self-assigned this Sep 26, 2024
@eyurtsev eyurtsev enabled auto-merge (squash) September 26, 2024 20:41
@eyurtsev
Copy link
Collaborator

Thank you @esciara

@eyurtsev eyurtsev merged commit c6350d6 into langchain-ai:master Sep 26, 2024
85 checks passed
Sheepsta300 pushed a commit to Sheepsta300/langchain that referenced this pull request Oct 1, 2024
…ai#26914)

**Description:** Replaced blocking (sync) rate_limiter code in async
methods.

**Issue:** langchain-ai#26913

**Dependencies:** N/A

**Twitter handle:** no need 🤗
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature Ɑ: core Related to langchain-core lgtm PR looks good. Use to confirm that a PR is ready for merging. size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants
  翻译: