-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New PowerToy] Add Screen Ruler module for measuring screen contents #19701
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Love this tool already😊! One quirk: should we disable measurement whenever the cursor is within the overlay toolbar? Therefore, controls can still be selected by mouse without using the ESC key first. This is also important for a11y I can imagine. |
Thanks for the feedback @niels9001 , I've added it to the checklist in the PRs description so we can keep track of the changes still needed. |
|
This comment was marked as resolved.
This comment was marked as resolved.
I saw the gifs in the description now. And I love yet until try it by myself. As I wrote somewhere it would be nice to have the ability of choosing the unit (mm, cm, px, zoll) and it would be great to have the unit abbreviation in the tooltip. Regarding the toolbar I suggest to change the cross capture icon in the toolbar to a cross to make it more clear. maybe the symbol We could use symbol |
Sent via email screenshots, i think for the horizontal bar is off by one. It is 1 px too high. I'm at 100% scale. Using it to measure the minimize button / maximize button as hit points, you can see it stops 1 px above minimize |
This comment was marked as outdated.
This comment was marked as outdated.
@niels9001 are you ok with merging this? :) I believe AutomationPeer changes are now addressed. |
# Conflicts: # .github/actions/spell-check/expect.txt # installer/PowerToysSetup/Product.wxs # src/runner/main.cpp # src/settings-ui/Settings.UI/OOBE/Views/OobeShellPage.xaml # src/settings-ui/Settings.UI/Views/ShellPage.xaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aaaawwwweeeesssssooooommmmmeeee 😄👍
when appropriate, (hoping today 😊), we can get this in so. I want to kick off a signed test build with all the new stuff and just be hyper critical of all the new stuff and what could be adjusted / should be adjusted before we release. |
Figuring out those last build CI errors and we'll be merging it afterwards 😉 |
Summary of the Pull Request
Bounds tool and measure tool is implemented.
Fixes
GetClientRect
with "Invalid window handle".PR Checklist