Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement P0943R6 Supporting C Atomics In C++ #2008

Merged
merged 9 commits into from
Aug 17, 2021
Merged

Implement P0943R6 Supporting C Atomics In C++ #2008

merged 9 commits into from
Aug 17, 2021

Conversation

AdamBucior
Copy link
Contributor

Resolves #1448.

@AdamBucior AdamBucior requested a review from a team as a code owner June 13, 2021 13:58
@StephanTLavavej StephanTLavavej added the cxx23 C++23 feature label Jun 14, 2021
@StephanTLavavej

This comment has been minimized.

Sign in to view
@StephanTLavavej StephanTLavavej self-assigned this Jun 30, 2021
StephanTLavavej
StephanTLavavej reviewed Aug 13, 2021
View reviewed changes
Copy link
Member

@StephanTLavavej StephanTLavavej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'll go ahead and push minor changes.

stl/inc/yvals_core.h Outdated Show resolved Hide resolved
stl/CMakeLists.txt Show resolved Hide resolved
tests/std/tests/P0943R6_stdatomic_h/test.compile.pass.cpp Outdated Show resolved Hide resolved
stl/inc/stdatomic.h Show resolved Hide resolved
@StephanTLavavej StephanTLavavej removed their assignment Aug 13, 2021
@StephanTLavavej StephanTLavavej self-assigned this Aug 14, 2021
@StephanTLavavej
Copy link
Member

I'm mirroring this to an MSVC-internal PR. It's totally fine to push changes for code review feedback, but please notify me in that case.

@StephanTLavavej StephanTLavavej merged commit 0680fab into microsoft:main Aug 17, 2021
@StephanTLavavej
Copy link
Member

Thanks for implementing this glowing feature! ☢️ 😹 ✔️

@AdamBucior AdamBucior deleted the stdatomic branch August 17, 2021 08:48
This was referenced Aug 18, 2021
Closed
Merged
@triplef triplef mentioned this pull request Mar 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miscco miscco miscco left review comments

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@CaseyCarter CaseyCarter CaseyCarter approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
cxx23 C++23 feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

P0943R6 Supporting C Atomics In C++
4 participants
@AdamBucior @StephanTLavavej @CaseyCarter @miscco
  翻译：