Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<chrono> Estimate width of aligned chronat strings #2017

Merged
merged 4 commits into from
Jun 29, 2021
Merged

<chrono> Estimate width of aligned chronat strings #2017

merged 4 commits into from
Jun 29, 2021

Conversation

MattStephanson
Copy link
Contributor

Fixes #2002.

@MattStephanson MattStephanson requested a review from a team as a code owner June 17, 2021 19:44
@CaseyCarter CaseyCarter added the bug Something isn't working label Jun 17, 2021
@StephanTLavavej StephanTLavavej added the chrono C++20 chrono label Jun 19, 2021
StephanTLavavej
StephanTLavavej reviewed Jun 22, 2021
View reviewed changes
Copy link
Member

@StephanTLavavej StephanTLavavej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I'll validate and push trivial test changes.

tests/std/tests/P0355R7_calendars_and_time_zones_formatting/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/P0355R7_calendars_and_time_zones_formatting/test.cpp Outdated Show resolved Hide resolved
@StephanTLavavej StephanTLavavej self-assigned this Jun 24, 2021
@StephanTLavavej StephanTLavavej merged commit 27b916f into microsoft:main Jun 29, 2021
@StephanTLavavej
Copy link
Member

Thanks for investigating and fixing this bug! 🪲 ✔️ 😺

@MattStephanson MattStephanson deleted the chronat-estimate-width branch June 29, 2021 22:13
@barcharcraz barcharcraz mentioned this pull request Oct 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
bug Something isn't working chrono C++20 chrono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<chrono>: incorrect estimated string width when formatting year_month_day into fullwidth character
3 participants
@MattStephanson @StephanTLavavej @CaseyCarter
  翻译：