Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update _MSVC_STL_VERSION to 143 and _MSVC_STL_UPDATE to August 2021 #2091

Merged
merged 1 commit into from
Aug 6, 2021
Merged

Update _MSVC_STL_VERSION to 143 and _MSVC_STL_UPDATE to August 2021 #2091

merged 1 commit into from
Aug 6, 2021

Conversation

joseherrera7
Copy link
Contributor

@joseherrera7 joseherrera7 commented Aug 2, 2021 •
edited
Loading

Closes #2090

@joseherrera7 joseherrera7 requested a review from a team as a code owner August 2, 2021 01:14
@fsb4000
Copy link
Contributor

fsb4000 commented Aug 2, 2021 •
edited
Loading

Add

Closes #2090

to your first comment

similar to that: #2086

@joseherrera7 joseherrera7 reopened this Aug 2, 2021
@CaseyCarter CaseyCarter added the documentation Related to documentation or comments label Aug 2, 2021
CaseyCarter
CaseyCarter approved these changes Aug 2, 2021
View reviewed changes
Copy link
Member

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@StephanTLavavej StephanTLavavej self-assigned this Aug 5, 2021
@StephanTLavavej StephanTLavavej merged commit bfa2cb2 into microsoft:main Aug 6, 2021
@StephanTLavavej
Copy link
Member

Thanks for updating these version numbers, and congratulations on your first microsoft/STL pull request! 😸 🎉 🚀

This will ship in VS 2022 17.0 Preview 4, and they'll also be the final values for VS 2022 17.0's production release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@fsb4000 fsb4000 fsb4000 approved these changes

@sam20908 sam20908 sam20908 approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
documentation Related to documentation or comments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<yvals_core.h>: Update _MSVC_STL_VERSION and _MSVC_STL_UPDATE
5 participants
@joseherrera7 @fsb4000 @StephanTLavavej @CaseyCarter @sam20908
  翻译：