Some Cpp Core Guidelines warning fixes #2116
Conversation
* The const variable '%1$s' can be computed at compile-time. Consider using constexpr (con.5). * Do not use function style C-casts (es.49). * Don't use reinterpret_cast. A cast from void* can use static_cast (type.1).
This comment was marked as resolved.
This comment was marked as resolved.
let's have them altogeter
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
@AlexGuteniev We talked about this at the weekly maintainer meeting - we like the product code changes here, but we're very worried about false positives from the static analyzer which could block GitHub PRs; we've been dealing with such issues when internally mirroring PRs. We think it would be reasonable to not add test coverage here, but instead to add something to tools/scripts that can manually run CppCoreCheck over the STL. In the future, it may be desirable to add automated test coverage, but in the meantime a manual script would allow on-demand investigations.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
I think for now we can (finally) land these product code changes, and consider a script to run CppCoreCheck in the future. Apologies for the delay here. I pushed a merge with |
|
I'm speculatively mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for fixing these warnings and improving the codebase! 🛠️ 😸 🎉 |
Do not use function style C-casts (es.49).