-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleared comment TRANSITION #2186
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexGuteniev
reviewed
Sep 3, 2021
StephanTLavavej
approved these changes
Sep 3, 2021
AlexGuteniev
approved these changes
Sep 4, 2021
fsb4000
approved these changes
Sep 4, 2021
StephanTLavavej
approved these changes
Sep 7, 2021
CaseyCarter
approved these changes
Sep 7, 2021
Status update: We merge PRs simultaneously on GitHub and in our MSVC-internal repo. As this is a semi-manual process, we batch up PRs to save effort. Your PR will be part of the next batch, likely at the end of this week. Thanks! |
Thanks for removing these outdated comments, and congratulations on your first microsoft/STL commit! 😺 🚀 🎉 This will ship in VS 2022 17.1 Preview 1. |
36 tasks
Thankyou @StephanTLavavej |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2182
this pr will close the above issue .
i had removed all the 11 occurences of
// TRANSITION, GH-489
across 4 files (<compare>
,<functional>
,<system_error>
, and<xutility>
).