Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleared comment TRANSITION #2186

Merged
merged 2 commits into from
Sep 11, 2021
Merged

Conversation

AnudeepGunukula
Copy link
Contributor

Closes #2182

this pr will close the above issue .
i had removed all the 11 occurences of // TRANSITION, GH-489 across 4 files (<compare>, <functional>, <system_error>, and <xutility>).

@AnudeepGunukula AnudeepGunukula requested a review from a team as a code owner September 3, 2021 15:40
@ghost
Copy link

ghost commented Sep 3, 2021

CLA assistant check
All CLA requirements met.

stl/inc/system_error Outdated Show resolved Hide resolved
@StephanTLavavej StephanTLavavej added the documentation Related to documentation or comments label Sep 3, 2021
@StephanTLavavej
Copy link
Member

Status update: We merge PRs simultaneously on GitHub and in our MSVC-internal repo. As this is a semi-manual process, we batch up PRs to save effort. Your PR will be part of the next batch, likely at the end of this week. Thanks!

@StephanTLavavej StephanTLavavej self-assigned this Sep 10, 2021
@StephanTLavavej StephanTLavavej merged commit 3d02211 into microsoft:main Sep 11, 2021
@StephanTLavavej
Copy link
Member

Thanks for removing these outdated comments, and congratulations on your first microsoft/STL commit! 😺 🚀 🎉

This will ship in VS 2022 17.1 Preview 1.

@AnudeepGunukula
Copy link
Contributor Author

Thankyou @StephanTLavavej

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Related to documentation or comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LWG-3530 BUILTIN-PTR-MEOW should not opt the type out of syntactic checks
5 participants
  翻译: