Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement LWG-3549 #2198

Merged
merged 1 commit into from
Sep 25, 2021
Merged

Implement LWG-3549 #2198

merged 1 commit into from
Sep 25, 2021

Conversation

CaseyCarter
Copy link
Member

Which (1) makes enable_view<T> be true for a type T which is publicly-and-unambigously derived from a single specialization of view_interface, and (2) removes view_interface's inheritance of view_base.

Fixes #2178

@CaseyCarter
Implement LWG-3549
8918d4c 
Which (1) makes `enable_view<T>` be `true` for a type `T` which is publicly-and-unambigously derived from a single specialization of `view_interface`, and (2) removes `view_interface`'s inheritance of `view_base`.

Fixes microsoft#2178
@CaseyCarter CaseyCarter added LWG Library Working Group issue ranges C++20/23 ranges defect report Applied retroactively labels Sep 10, 2021
@CaseyCarter CaseyCarter requested a review from a team as a code owner September 10, 2021 23:29
@StephanTLavavej StephanTLavavej self-assigned this Sep 15, 2021
@StephanTLavavej StephanTLavavej removed their assignment Sep 17, 2021
@mnatsuhara mnatsuhara self-assigned this Sep 22, 2021
@StephanTLavavej StephanTLavavej self-assigned this Sep 23, 2021
@StephanTLavavej
Copy link
Member

I'm mirroring this to an MSVC-internal PR. Please notify me if any further changes are pushed.

@mnatsuhara mnatsuhara removed their assignment Sep 23, 2021
@StephanTLavavej StephanTLavavej merged commit d4d409e into microsoft:main Sep 25, 2021
@StephanTLavavej
Copy link
Member

Thanks for implementing this LWG issue resolution! I discovered that if you look at the word "view" often enough, it starts to look brain-meltingly strange. 🤯 🧠 🥵 😹

@CaseyCarter CaseyCarter deleted the lwg3549 branch September 27, 2021 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@mnatsuhara mnatsuhara mnatsuhara approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
defect report Applied retroactively LWG Library Working Group issue ranges C++20/23 ranges
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LWG-3549 view_interface is overspecified to derive from view_base
3 participants
@CaseyCarter @StephanTLavavej @mnatsuhara
  翻译：