Move u*streampos to iosfwd #2223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
reviewed
Sep 28, 2021
| @@ -136,6 +136,11 @@ private: | |||
|
|
|||
| using streampos = fpos<_Mbstatet>; | |||
| using wstreampos = streampos; | |||
There was a problem hiding this comment.
Nitpick: the "conventional" ordering is
- char
- char8_t
- char16_t
- char32_t
- wchar_t
There was a problem hiding this comment.
I've approved, because I mildly prefer this ordering with "characters with native/locale-dependent encoding" before "characters with fixed encodings" - Yes, despite that wchar_t is fixed in practice - but I certainly wouldn't object to reordering.
There was a problem hiding this comment.
Same here, I just cannot resist to ring the "inconsistency" bell
miscco
approved these changes
Sep 28, 2021
CaseyCarter
approved these changes
Sep 28, 2021
fsb4000
approved these changes
Sep 29, 2021
StephanTLavavej
approved these changes
Oct 14, 2021
|
I'm mirroring this to an MSVC-internal PR; please notify me if any further changes are pushed. |
|
Thanks for finding and fixing this normative issue hidden in a massive wording overhaul! 😸 🎉 ✔️ |
AreaZR
pushed a commit
to AreaZR/STL
that referenced
this pull request
Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
P1148R0 says
u16streamposandu32streamposare defined in<iosfwd>(before P1148R0, their abode was unspecified). P0482R6 addsu8streamposto<iosfwd>.