<yvals_core.h> Remove unnecessary _HAS_CXX23 definition #2226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lready in <vcruntime.h>
miscco
approved these changes
Oct 1, 2021
miscco
reviewed
Oct 1, 2021
CaseyCarter
approved these changes
Oct 1, 2021
fsb4000
approved these changes
Oct 1, 2021
sam20908
approved these changes
Oct 2, 2021
mnatsuhara
approved these changes
Oct 9, 2021
|
I'm mirroring this to an MSVC-internal PR; please notify me if any further changes are pushed. |
|
Thanks for removing this unnecessary code, and congratulations on your first microsoft/STL commit! 🎉 😸 🚀 This change will be available in VS 2022 17.1 Preview 2. |
AreaZR
pushed a commit
to AreaZR/STL
that referenced
this pull request
Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The symbol is already defined in <vcruntime.h> so it's redundant here.
Fixes #2214