Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement LWG-3557: The static_cast expression in convertible_to has the wrong operand #2406

Merged
merged 3 commits into from
Dec 17, 2021
Merged

Implement LWG-3557: The static_cast expression in convertible_to has the wrong operand #2406

merged 3 commits into from
Dec 17, 2021

Conversation

fsb4000
Copy link
Contributor

@fsb4000 fsb4000 commented Dec 11, 2021

Fixes #2394

@fsb4000 fsb4000 requested a review from a team as a code owner December 11, 2021 17:46
miscco
miscco reviewed Dec 11, 2021
View reviewed changes
stl/inc/concepts Outdated Show resolved Hide resolved
@fsb4000 @miscco
missing _STD
344ce8e 
Co-authored-by: Michael Schellenberger Costa <mschellenbergercosta@gmail.com>
@fsb4000 fsb4000 changed the title Implement LWG-3557 Implement LWG-3557: The static_cast expression in convertible_to has the wrong operand Dec 12, 2021
@CaseyCarter CaseyCarter added the LWG Library Working Group issue label Dec 12, 2021
CaseyCarter
CaseyCarter approved these changes Dec 16, 2021
View reviewed changes
Copy link
Member

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For posterity: I'm fine accepting this without test changes because the before and after conditions have equivalent observable behavior. This change is really a specification tweak masquerading as a change in product code.

@StephanTLavavej StephanTLavavej self-assigned this Dec 16, 2021
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 4b9ab17 into microsoft:main Dec 17, 2021
@StephanTLavavej
Copy link
Member

Thanks for implementing another LWG issue resolution! 🚀 🚀 😻

@fsb4000 fsb4000 deleted the fix2394 branch December 17, 2021 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miscco miscco miscco approved these changes

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@sam20908 sam20908 sam20908 approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
LWG Library Working Group issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LWG-3557 The static_cast expression in convertible_to has the wrong operand
5 participants
@fsb4000 @StephanTLavavej @CaseyCarter @miscco @sam20908
  翻译：