Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated _MSVC_STL_UPDATE to January 2022 #2455

Merged
merged 1 commit into from
Jan 6, 2022
Merged

updated _MSVC_STL_UPDATE to January 2022 #2455

merged 1 commit into from
Jan 6, 2022

Conversation

ssenthilnathan3
Copy link
Contributor

@ssenthilnathan3 ssenthilnathan3 commented Jan 3, 2022 •
edited
Loading

Fixes #2454

@ssenthilnathan3 ssenthilnathan3 requested a review from a team as a code owner January 3, 2022 05:21
@ssenthilnathan3 ssenthilnathan3 mentioned this pull request Jan 3, 2022
Closed
fsb4000
fsb4000 reviewed Jan 3, 2022
View reviewed changes
Copy link
Contributor

@fsb4000 fsb4000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add Fixes #2454 to your PR description.

Similar to my PR: #2443

miscco
miscco approved these changes Jan 3, 2022
View reviewed changes
Copy link
Contributor

@miscco miscco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations for your first PR 🎉

@ssenthilnathan3
Copy link
Contributor Author

Congratulations for your first PR 🎉

Thankyou.

@CaseyCarter CaseyCarter added the documentation Related to documentation or comments label Jan 3, 2022
@CaseyCarter CaseyCarter added enhancement Something can be improved and removed documentation Related to documentation or comments labels Jan 4, 2022
ddr533
ddr533 approved these changes Jan 4, 2022
View reviewed changes
Copy link
Contributor

@ddr533 ddr533 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@ssenthilnathan3
Copy link
Contributor Author

ssenthilnathan3 commented Jan 4, 2022 •
edited
Loading

Nice work!

Thank you.

@CaseyCarter CaseyCarter self-assigned this Jan 6, 2022
@CaseyCarter
Copy link
Member

I'm going to add this to the next batch of changes to merge - please notify me if any further commits are pushed.

@CaseyCarter CaseyCarter merged commit 0dc93fc into microsoft:main Jan 6, 2022
@CaseyCarter
Copy link
Member

Thanks for the update and congratulations on your first STL commit! 🎉🎉🎉 😹

@CaseyCarter CaseyCarter removed their assignment Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@miscco miscco miscco approved these changes

@fsb4000 fsb4000 fsb4000 approved these changes

@sam20908 sam20908 sam20908 approved these changes

@mnatsuhara mnatsuhara mnatsuhara approved these changes

@ddr533 ddr533 ddr533 approved these changes

Assignees
No one assigned
Labels
enhancement Something can be improved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<yvals_core.h>: Update _MSVC_STL_UPDATE to January 2022
7 participants
@ssenthilnathan3 @CaseyCarter @miscco @fsb4000 @sam20908 @mnatsuhara @ddr533
  翻译：