Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcd/lcm test from internal repo with questionable bits extracted #2507

Merged
merged 2 commits into from
Feb 1, 2022

Conversation

CaseyCarter
Copy link
Member

Partially addresses VSO-936680

@CaseyCarter CaseyCarter added the test Related to test code label Jan 27, 2022
@CaseyCarter CaseyCarter requested a review from a team as a code owner January 27, 2022 20:37
@CaseyCarter CaseyCarter marked this pull request as draft January 27, 2022 20:48
@StephanTLavavej StephanTLavavej self-assigned this Jan 31, 2022
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

Copy link
Member

@barcharcraz barcharcraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we prefer the test.compile.pass.cpp format over just test.cpp now?

@CaseyCarter
Copy link
Member Author

do we prefer the test.compile.pass.cpp format over just test.cpp now?

Yes we do. The GitHub test runner recognizes the suffix .compile.pass.cpp and it won't attempt to link and run such test cases.

@StephanTLavavej
Copy link
Member

One note about test.compile.pass.cpp - such tests must still be prepared to be linked and ran with no effect, since the internal test harness doesn't know to skip those steps. (It could presumably be enlightened, but teaching that ancient Perl machinery anything is quite difficult.)

@StephanTLavavej StephanTLavavej merged commit c6df0b0 into microsoft:main Feb 1, 2022
@StephanTLavavej
Copy link
Member

Thanks for being the Greatest Casey Denominator! 😹 🔼 🎉

@CaseyCarter CaseyCarter deleted the gcdlcm branch February 1, 2022 04:20
@StephanTLavavej StephanTLavavej mentioned this pull request May 28, 2024
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Related to test code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
  翻译: