P2393R1 Cleaning Up Integer-Class Types #2541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our integer-class types (`_Signed128` and `_Unsigned128`) were implemented to the revised wording, so they require no changes. We _do_ need the `subrange` constructor change. We don't need the `drop_view`, `take_view`, `views::counted`, and `views::take` changes. We already implement them or something functionally equivalent. Update `<yvals_core.h>` to indicate that P2393R1 is implemented in C++20 (and later) modes. Drive-by: Indicate that P1522 is now fully implemented in `<yvals_core.h>`. Fixes microsoft#2254
StephanTLavavej
approved these changes
Feb 9, 2022
AlexGuteniev
approved these changes
Feb 10, 2022
Please try to drive this into 2019 as well? |
|
I'm mirroring this to the MSVC-internal repo. Requesting or pushing changes is totally fine, but please notify me if that happens. |
mnatsuhara
approved these changes
Feb 11, 2022
|
Thanks for cleaning up these fundamental building blocks of arithmetic! 🧹 ➕ 🔢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our integer-class types (
_Signed128and_Unsigned128) were implemented to the revised wording, so they require no changes.We do need the
subrangeconstructor change.We don't need the
drop_view,take_view,views::counted, andviews::takechanges. We already implement them or something functionally equivalent.Update
<yvals_core.h>to indicate that P2393R1 is implemented in C++20 (and later) modes.Drive-by: Indicate that P1522 is now fully implemented in
<yvals_core.h>.Fixes #2254
There's no test coverage here because it just seems silly to write two ranges with custom iterators just to verify the presence of one
static_cast. As always, reviewers - yell at me if you disagree.