Implement LWG-3618 Unnecessary iter_move for transform_view::iterator
#2566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaseyCarter
approved these changes
Feb 14, 2022
StephanTLavavej
requested changes
Feb 15, 2022
StephanTLavavej
requested changes
Feb 15, 2022
…filter_view::_Check_dereference`
This comment was marked as resolved.
This comment was marked as resolved.
CaseyCarter
approved these changes
Feb 16, 2022
StephanTLavavej
approved these changes
Feb 16, 2022
This comment was marked as resolved.
This comment was marked as resolved.
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. (I'll handle verifying that this works with the recent LLVM update.) |
StephanTLavavej
added a commit
to StephanTLavavej/STL
that referenced
this pull request
Feb 17, 2022
|
I've pushed an update to the libcxx skips, as deref and |
StephanTLavavej
approved these changes
Feb 17, 2022
CaseyCarter
approved these changes
Feb 17, 2022
|
Thanks for transforming the STL to implement this LWG issue! 🎉 😹 😸 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2554