Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanups 6: iostreams: drop extern, hide _Winit #2678

Merged

Conversation

StephanTLavavej
Copy link
Member

  • <fstream>, <xlocnum>: _Fiopen() and the _Stofx() family don't need to be declared as extern (that's the default, and we don't say extern when declaring other separately compiled functions).
    • Noticed while implementing Standard Library Modules, where I'll have to add extern "C++" which is different.
  • <iostream>: Prevent _Winit from being seen by users.
    • Nothing else mentions this, so we don't need to declare it for users. We still need to export it to preserve bincompat, but I believe that it is completely dead (nothing constructs an object of this type, nor the macroized _UShinit), so I'm adding a comment that it appears to be unused (and thus can be completely removed during vNext).

@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Apr 27, 2022
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner April 27, 2022 22:11
@strega-nil-ms strega-nil-ms self-assigned this Apr 27, 2022
@CaseyCarter CaseyCarter removed their assignment Apr 28, 2022
@strega-nil-ms strega-nil-ms removed their assignment Apr 28, 2022
@StephanTLavavej StephanTLavavej self-assigned this Apr 30, 2022
@StephanTLavavej
Copy link
Member Author

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 64afd79 into microsoft:main May 1, 2022
@StephanTLavavej StephanTLavavej deleted the cleanups-6-iostreams branch May 1, 2022 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Something can be improved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
  翻译: