Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workaround for std::source_location::current() #2824

Merged
merged 1 commit into from
Jul 1, 2022

Conversation

fsb4000
Copy link
Contributor

@fsb4000 fsb4000 commented Jun 25, 2022

Fixes #2822

@fsb4000 fsb4000 requested a review from a team as a code owner June 25, 2022 17:31
@StephanTLavavej StephanTLavavej added the bug Something isn't working label Jun 25, 2022
@StephanTLavavej StephanTLavavej changed the title workaround(?) for std::source_location::current() workaround for std::source_location::current() Jun 28, 2022
@StephanTLavavej
Copy link
Member

Thanks for filing DevCom-10080771. As the compiler bug has been reported, the workaround is small and non-disruptive, and you're adding test coverage, I'm fine with this being an uncommented perma-workaround.

@StephanTLavavej StephanTLavavej self-assigned this Jun 30, 2022
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 0e29ddb into microsoft:main Jul 1, 2022
@StephanTLavavej
Copy link
Member

Thanks for reporting and working around this compiler bug! 🐞 🛠️ 🎉

@fsb4000 fsb4000 deleted the fix2822 branch July 1, 2022 04:11
fsb4000 added a commit to fsb4000/STL that referenced this pull request Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants
  翻译: