Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement P2517R1: Conditional noexcept For apply #2959

Merged
merged 5 commits into from
Aug 3, 2022
Merged

Implement P2517R1: Conditional noexcept For apply #2959

merged 5 commits into from
Aug 3, 2022

Conversation

strega-nil-ms
Copy link
Contributor

@strega-nil-ms strega-nil-ms commented Jul 27, 2022 •
edited by CaseyCarter
Loading

Fixes #2938

For review purposes: P2517R1.zip

@strega-nil-ms strega-nil-ms requested a review from a team as a code owner July 27, 2022 19:04
@CaseyCarter CaseyCarter added the cxx23 C++23 feature label Jul 27, 2022
CaseyCarter
CaseyCarter requested changes Jul 27, 2022
View reviewed changes
Copy link
Member

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Product code is great, but we should have test coverage with at least one noexcept and one !noexcept case.

@StephanTLavavej
Copy link
Member

@strega-nil-ms @CaseyCarter FYI, I pushed a conflict-free merge with main followed by changes to fix the internal test harness and do the other things. Should be non-controversial but please meow if you have any meows.

@strega-nil-ms
Copy link
Contributor Author

LGTM, thanks!

miscco
miscco approved these changes Jul 29, 2022
View reviewed changes
Copy link
Contributor

@miscco miscco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I refuse to say that this looks good to me, but I approve the changes

@StephanTLavavej StephanTLavavej self-assigned this Aug 3, 2022
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit c231f7f into microsoft:main Aug 3, 2022
@StephanTLavavej
Copy link
Member

Thanks for strengthening our C++23 conformance! 🦾 😹 🎉

strega-nil added a commit to strega-nil/stl that referenced this pull request Aug 6, 2022
@strega-nil-ms @strega-nil @StephanTLavavej
Implement P2517R1: Conditional noexcept For apply (microsoft#2959)
3ba5ad0 
Co-authored-by: Nicole Mazzuca <mazzucan@outlook.com>
Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
fsb4000 pushed a commit to fsb4000/STL that referenced this pull request Aug 13, 2022
@strega-nil-ms @strega-nil
@StephanTLavavej @fsb4000
Implement P2517R1: Conditional noexcept For apply (microsoft#2959)
abafd30 
Co-authored-by: Nicole Mazzuca <mazzucan@outlook.com>
Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
@strega-nil-ms strega-nil-ms deleted the p2517 branch December 19, 2022 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@miscco miscco miscco approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
cxx23 C++23 feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

P2517R1 Conditional noexcept For apply()
5 participants
@strega-nil-ms @StephanTLavavej @CaseyCarter @miscco @strega-nil
  翻译：