Clean up validation #3082
Merged
Clean up validation #3082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can use ranges::is_sorted and ranges::binary_search and pass the checked extensions instead of passing the iterators directly.
AlexGuteniev
approved these changes
Sep 7, 2022
StephanTLavavej
approved these changes
Sep 7, 2022
|
Thanks! The use of the ranges algorithms here is a definite improvement (much less verbose). The mem-initializer-list change is a minor improvement (I agree that it's generally better to initialize members to their desired values instead of assigning them later). As I mentioned, I'm neutral on the addition of |
Closed
AraHaan
approved these changes
Sep 8, 2022
strega-nil-ms
suggested changes
Sep 12, 2022
StephanTLavavej
approved these changes
Sep 12, 2022
CaseyCarter
reviewed
Sep 12, 2022
CaseyCarter
approved these changes
Sep 12, 2022
StephanTLavavej
approved these changes
Sep 12, 2022
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
strega-nil-ms
approved these changes
Sep 12, 2022
|
Thanks for this code cleanup! 😸 |
CaseyCarter
added a commit
to CaseyCarter/STL
that referenced
this pull request
Oct 6, 2022
Co-authored-by: Stephan T. Lavavej <stl@nuwen.net> Co-authored-by: Casey Carter <Casey@Carter.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can use ranges::is_sorted and ranges::binary_search and pass the checked extensions instead of passing the iterators directly.