Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workaround DevCom-10247495 #3331

Merged
merged 1 commit into from
Jan 12, 2023
Merged

workaround DevCom-10247495 #3331

merged 1 commit into from
Jan 12, 2023

Conversation

fsb4000
Copy link
Contributor

@fsb4000 fsb4000 commented Jan 8, 2023

@fsb4000 fsb4000 requested a review from a team as a code owner January 8, 2023 10:00
@StephanTLavavej StephanTLavavej added bug Something isn't working modules C++23 modules, C++20 header units labels Jan 9, 2023
@StephanTLavavej StephanTLavavej mentioned this pull request Jan 9, 2023
Closed
@StephanTLavavej
Copy link
Member

Thanks for investigating this, reporting it to the compiler team, and finding a workaround! I think that adding this workaround without adding test coverage is reasonable, given that the other bug #3333 in this area has no known library workaround.

@StephanTLavavej StephanTLavavej self-assigned this Jan 11, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit dc14f49 into microsoft:main Jan 12, 2023
@StephanTLavavej
Copy link
Member

Thanks again! This compiler bug has been fixed by @cdacamar for VS 2022 17.6 Preview 2, so we'll be able to remove this workaround soon-ish. 📆 🎉 😻

@fsb4000 fsb4000 deleted the fix3330 branch January 12, 2023 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
bug Something isn't working modules C++23 modules, C++20 header units
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

std::filesystem::directory_iterator code compiles OK with <filesytem> fails with std module, 17.5 Preview 2
3 participants
@fsb4000 @StephanTLavavej @strega-nil-ms
  翻译：