Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<xhash>: Use ceiling instead of rounding when calculating number of buckets #3687

Merged
merged 1 commit into from
May 18, 2023
Merged

<xhash>: Use ceiling instead of rounding when calculating number of buckets #3687

merged 1 commit into from
May 18, 2023

Conversation

MattStephanson
Copy link
Contributor

Fixes #732.

@MattStephanson MattStephanson requested a review from a team as a code owner May 10, 2023 03:12
@StephanTLavavej StephanTLavavej added the bug Something isn't working label May 10, 2023
@CaseyCarter CaseyCarter self-assigned this May 10, 2023
@StephanTLavavej StephanTLavavej self-assigned this May 10, 2023
@StephanTLavavej StephanTLavavej removed their assignment May 12, 2023
@StephanTLavavej
Copy link
Member

Looks great, thank you! I convinced myself that there are no ABI implications because this only alters the behavior of reserve() and the actual number of buckets is always a power of 2.

@StephanTLavavej StephanTLavavej self-assigned this May 17, 2023
@StephanTLavavej
Copy link
Member

I'm speculatively mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@CaseyCarter CaseyCarter removed their assignment May 17, 2023
@CaseyCarter CaseyCarter merged commit d95d3bb into microsoft:main May 18, 2023
@CaseyCarter
Copy link
Member

Thanks! This change has me dancing on the ceiling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<xhash>: reserve() isn't computing the ceiling properly
4 participants
@MattStephanson @StephanTLavavej @CaseyCarter @strega-nil-ms
  翻译：