Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not require github username / password #702

Open
chrissound opened this issue Jan 15, 2020 · 2 comments
Open

Do not require github username / password #702

chrissound opened this issue Jan 15, 2020 · 2 comments

Comments

@chrissound
Copy link

chrissound commented Jan 15, 2020

#645

This is horrifying that you require a username / password of github just to "encrypt" some variables. It's a serious security issue, and should probably be handled by Oath with Github's API instead.

@Benjamin-Dobell
Copy link

TravisCi doesn't ever ask you for your Github password. It logs in to your Github account using tokens.

However, there is a related issue that travis-ci.com requires way more permission than necessary just to login from CLI, namely:

  • read:org
  • repo
  • user:email

If you've already got an account with TravisCI then it's already been granted OAuth permissions. In which case the token to login from CLI shouldn't require any scopes at all i.e. You're just proving to TravisCI that you are a particular Github user; that's it.

@vatosarmat
Copy link

As you can see above, it will ask you for your GitHub user name and password, but not send these to Travis CI. Instead, it will use them to create a GitHub API token

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
  翻译: