Migrate usage of Database::select to SelectQueryBuilder in OAuth
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Maintenance_bot
	Jul 7 2022, 6:28 AM

Description

Now that T243051: A query builder for MediaWiki core is done, this extension should migrate away from IDatabase::select() to SelectQueryBuilder.

It would improve readability of the code, avoids mistakes by passing the wrong order of arguments, etc.

For more information check T243051 and its documentation.

Note that query builder is a different paradigm and changes should not be one-to-one. For example, avoid using joinConds().

	Subject	Repo	Branch	Lines +/-
	Migrate to IReadableDatabase::newSelectQueryBuilder	mediawiki/extensions/OAuth	master	+103 -89
	Replace usage of select() with newSelectQueryBuilder()	mediawiki/extensions/OAuth	master	+102 -107

		Status	Subtype	Assigned	Task
		Resolved		None	T311866 Migrate Database::select usages to SelectQueryBuilder (in WMF-deployed extensions)
		Resolved		Umherirrender	T312476 Migrate usage of Database::select to SelectQueryBuilder in OAuth

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 7 2022, 6:28 AM

Change 1009828 had a related patch set uploaded (by MPGuy2824; author: MPGuy2824):

[mediawiki/extensions/OAuth@master] Replace usage of select() with newSelectQueryBuilder()

Change #1009828 merged by jenkins-bot:

[mediawiki/extensions/OAuth@master] Replace usage of select() with newSelectQueryBuilder()

Change #1023943 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/OAuth@master] Migrate to IReadableDatabase::newSelectQueryBuilder

Change #1023943 merged by jenkins-bot:

[mediawiki/extensions/OAuth@master] Migrate to IReadableDatabase::newSelectQueryBuilder